Load sqlcipher library asynchronously #6733
Open
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikescamell
force-pushed
the
feature/mike/load-sqlcipher-async
branch
from
c8f8527 to
1cb406d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR implements asynchronous SQLCipher library loading by adding LibraryLoaderListener interface support to RealSecureStorageDatabaseFactory. The change improves error handling and logging for SQLCipher library initialization.
Key changes:
- Implements
LibraryLoaderListenerinterface with success/failure callbacks - Adds comprehensive error handling with try-catch blocks
- Improves logging messages for better debugging
...mpl/src/main/java/com/duckduckgo/autofill/impl/securestorage/SecureStorageDatabaseFactory.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1210918149098144
Description
Implemented
LibraryLoaderListenerinterface inRealSecureStorageDatabaseFactoryto properly handle SQLCipher library loading success and failure callbacks. This change improves error handling by:Steps to test this PR
SQLCipher Library Loading
UI changes